jbonofre commented on code in PR #739: URL: https://github.com/apache/camel-karaf/pull/739#discussion_r3872608136
########## core/camel-core-osgi/src/test/java/org/apache/camel/karaf/core/OsgiTypeConverterTest.java: ########## @@ -17,7 +17,20 @@ package org.apache.camel.karaf.core; import org.apache.camel.CamelContext; +import org.apache.camel.RuntimeCamelException; +import org.apache.camel.TypeConverter; import org.apache.camel.spi.Injector; +import java.util.ArrayList; Review Comment: **The new `java.util` imports were inserted into the middle of the existing `org.apache.camel` group, splitting it in two.** Lines 19-22 are `org.apache.camel.*`, lines 23-31 are `java.util.*`, then line 33 returns to `org.apache.camel.impl.converter.DefaultTypeConverter` and `org.apache.camel.spi.*`. `OsgiTypeConverter.java` itself (lines 19-28) and the rest of the module put `java.*` first, then a blank line, then the third-party groups. There is no enforced formatter plugin here so nothing fails the build, but this guarantees a churn diff the next time anyone runs an IDE import organiser over the file. ########## core/camel-core-osgi/src/test/java/org/apache/camel/karaf/core/OsgiTypeConverterTest.java: ########## @@ -17,7 +17,20 @@ package org.apache.camel.karaf.core; import org.apache.camel.CamelContext; +import org.apache.camel.RuntimeCamelException; +import org.apache.camel.TypeConverter; import org.apache.camel.spi.Injector; +import java.util.ArrayList; Review Comment: **The new `java.util` imports were inserted into the middle of the existing `org.apache.camel` group, splitting it in two.** Lines 19-22 are `org.apache.camel.*`, lines 23-31 are `java.util.*`, then line 33 returns to `org.apache.camel.impl.converter.DefaultTypeConverter` and `org.apache.camel.spi.*`. `OsgiTypeConverter.java` itself (lines 19-28) and the rest of the module put `java.*` first, then a blank line, then the third-party groups. There is no enforced formatter plugin here so nothing fails the build, but this guarantees a churn diff the next time anyone runs an IDE import organiser over the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
