jbonofre commented on code in PR #739: URL: https://github.com/apache/camel-karaf/pull/739#discussion_r3860502131
########## core/camel-core-osgi/src/test/java/org/apache/camel/karaf/core/OsgiTypeConverterTest.java: ########## @@ -17,7 +17,19 @@ package org.apache.camel.karaf.core; import org.apache.camel.CamelContext; +import org.apache.camel.RuntimeCamelException; +import org.apache.camel.TypeConverter; import org.apache.camel.spi.Injector; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicInteger; Review Comment: Style: the `java.util.*` imports landed after the `org.apache.camel.*` block, splitting it in two. Everywhere else in this file and in `OsgiTypeConverter.java` the order is `java.*`, blank line, `org.*`. Please move these above `org.apache.camel.CamelContext`. _Claude Code on behalf of JB Onofré_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
