davsclaus commented on PR #24693: URL: https://github.com/apache/camel/pull/24693#issuecomment-4977278735
Thanks @gnodet for catching the batching regression! Addressed in the latest commit: **Batching auto-commit regression** — Fixed by merging the `batching` check into `isAutoCommitEnable()`, which now returns `offsetRepository == null && !batching && autoCommitEnable`. This makes it the single source of truth for whether the component controls offset commits. Additionally, the rebalance listeners (`ClassicRebalanceListener` and `ResumeRebalanceListener`) were migrated from `getAutoCommitEnable()` to `isAutoCommitEnable()`. This also fixes a **pre-existing bug**: with `offsetRepository` configured, the rebalance listeners were not committing offsets on partition revoke because `getAutoCommitEnable()` only checked `batching`, not `offsetRepository`. `getAutoCommitEnable()` has been deprecated — it now delegates to `isAutoCommitEnable()`. Added a test for the batching auto-commit case. _Claude Code on behalf of @davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
