davsclaus opened a new pull request, #24693:
URL: https://github.com/apache/camel/pull/24693

   ## Summary
   
   Fixes 11 medium-severity findings from the camel-kafka code review tracked 
in [CAMEL-23997](https://issues.apache.org/jira/browse/CAMEL-23997):
   
   **Configuration:**
   - `sslEndpointAlgorithm=none` now correctly disables hostname verification 
(sets empty string instead of omitting)
   - `offsetRepository` now properly disables Kafka auto-commit (uses 
`isAutoCommitEnable()` instead of `getAutoCommitEnable()`)
   - `sendBufferBytes` now applied to consumers on PLAINTEXT (was stuck inside 
SSL-only block)
   
   **Consumer:**
   - Reconnect flag is now properly reset after successful reconnect (was never 
reset due to copy-paste bug from CAMEL-17244)
   - Auto-generated `groupId` is now shared across all consumer threads 
(previously each thread got a unique UUID)
   
   **Producer (batch/iterator mode):**
   - Plain list elements are now type-converted via the configured serializer
   - Keys of `List<Message>` elements are now properly converted (uses fallback 
exchange)
   - Endpoint-configured `key=` is now respected for batch elements lacking the 
`CamelKafkaKey` header
   - Per-element header recomputation fixed in the plain-element branch (uses 
cached path)
   - `DefaultKafkaHeaderSerializer` CamelContext is now injected in 
`KafkaProducer.doStart()`
   
   **Kamelet transforms:**
   - `ReplaceField`: renames parsing now guarded by `renames` variable instead 
of `disabled` (copy-paste fix)
   - `MessageTimestampRouter`: now searches for the first key *present in the 
payload*, not just the first non-empty key name; also fixes 
`ClassCastException` for numeric timestamp fields
   
   ## Test plan
   
   - [x] New `KafkaConfigurationTest` (4 tests) — verifies SSL algorithm, 
offset repository auto-commit, and sendBufferBytes
   - [x] New `KafkaConsumerTest.autoGeneratedGroupIdIsSharedAcrossCalls` — 
verifies shared groupId
   - [x] New `ReplaceFieldTest.shouldRenameFieldsWithoutDisabledSet` — verifies 
renames work without disabled parameter
   - [x] New `MessageTimestampRouterTest` (3 tests) — verifies key fallback, 
numeric timestamps, and missing key behavior
   - [x] `mvn clean install` passes (155 tests, 0 failures)
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   Co-Authored-By: Claude Opus 4.6 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to