cfitzw commented on PR #5996: URL: https://github.com/apache/camel-k/pull/5996#issuecomment-2571317028
@squakez I've committed back in the info log line, however, this does make me question the purpose of including the condition and return statement? Maybe the sole purpose of adding the condition is to allow for tests to evaluate the result (which I've now added too...)? FYI: The `openapi.go` trait is using a very similar logic, without the log line, however, as alluded to above, `openapi_test.go` does have a test condition where the same message text is evaluated... though the message would never be seen by folks. Same with `deployer.go` trait, except no test exists. It almost seems like there should be a package for throwing depreciation notices to keep better consistency and to provide better awareness (for those not following docs/commits), in some way? Nonetheless, this should now be complete/ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
