squakez commented on PR #5996:
URL: https://github.com/apache/camel-k/pull/5996#issuecomment-2568112328

   > @squakez, I added this into the configure function:
   > 
   > ```go
   > if t.Path != "" {
   >    if e.IntegrationInPhase(v1.IntegrationPhaseRunning) {
   >            m := "The path parameter is deprecated and may be removed in 
future releases. Use the paths parameter instead."
   >            t.L.Info(m)
   >            condition := NewIntegrationCondition(
   >                    "Ingress",
   >                    v1.IntegrationConditionTraitInfo,
   >                    corev1.ConditionTrue,
   >                    TraitConfigurationReason,
   >                    m,
   >            )
   > 
   >            return true, condition, nil
   >    }
   > }
   > ```
   > 
   > Questions:
   > 
   >     1. When I look at the operator log, I do see the warning/info message, 
however, it is listed multiple times (x3, even after limiting it to running 
state). I also needed to add t.L.Info(m) in order to see it in the operator log 
(I think...).
   > 
   >     2. I don't believe I am doing this correctly -- can you please assist?
   
   I don't see this in any commit. Have you committed it yet? The condition 
looks fine, but you don't need to add a log (the operator will log the 
condition message by default) and probably you won't need to check either the 
phase. It is possible that any trait runs multiple time, so, that's something 
you should not generally worry about.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to