squakez commented on code in PR #1282: URL: https://github.com/apache/camel-spring-boot/pull/1282#discussion_r1843613449
########## components-starter/camel-observability-services-starter/src/main/resources/config/application.properties: ########## @@ -0,0 +1,21 @@ + +## --------------------------------------------------------------------------- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --------------------------------------------------------------------------- + +management.endpoints.web.exposure.include=prometheus +management.endpoints.web.base-path=/camel Review Comment: > ah, do I understand correctly, the base-path refer to the actuators path? for example localhost:8080/actuators/camel? The base path would only refer to the actuators exposed. So, instead of `/actuator/health` we'll have `/camel/health`. However, as I said, the idea is to bring into this component all the different endpoints, so, in theory, when the user is using this, he should know that the expected endpoints are published under this normalize url. Of course, I would not expect the user to use this component + other components which are exposing actuators (say, health). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
