squakez commented on code in PR #1282: URL: https://github.com/apache/camel-spring-boot/pull/1282#discussion_r1843610824
########## components-starter/camel-observability-services-starter/src/main/resources/config/application.properties: ########## @@ -0,0 +1,21 @@ + +## --------------------------------------------------------------------------- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --------------------------------------------------------------------------- + +management.endpoints.web.exposure.include=prometheus +management.endpoints.web.base-path=/camel Review Comment: > Ah yeah that is correct using `/camel` is not the best idea We could use a new term to avoid clashes `/camel-observability` - its a bit long to type, but SB uses `/actuator` and quarkus uses `/q`. That's the idea of this component, "to normalize" the endpoints across the different runtimes. Consider that all the actuators should be eventually exposed with this normalized endpoints (in all runtimes). If the user does not want to do that, then, it should not use this component at all IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
