jakubmalek commented on PR #14926:
URL: https://github.com/apache/camel/pull/14926#issuecomment-2252143767
I've made some changes:
* First I've replaced the `Sqs2PollingClientTest` with `Sqs2ConsumerTest`
where I test the logic using `Consumer` API
* This way its irrelevant how the implementation is done inside the
consumer, so I think its better this way
* In terms of the testing I've also decided to switch to the
`AmazonSQSClientMock` instead of Mockito, so I extended it a bit
* Second, I've moved the `Sqs2PollingClient` to `Sqs2Consumer.PollingTask`
class
* In general it's not really a scheduled task, as
`ScheduledBatchPollingConsumer` already does the scheduling, so I'm simply
calling the "task" on the poll method inside the consumer
* I was considering option to simply get rid of the dedicated task class,
and simply put the implementation in the consumer class but I liked that its
separated, but if you think its too artificial, I'm open to suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
