orpiske commented on PR #14926: URL: https://github.com/apache/camel/pull/14926#issuecomment-2249697353
> Thanks for the comments, I will try to adapt to the task approach, although I'm not sure if I should refactor the consumer code to schedule the task in fixed period, or to re-use existing abstraction of `ScheduledBatchPollingConsumer` and simply move the logic into the existing `poll` method. Personally, I'd prefer the `ScheduledBatchPollingConsumer` approach because I think it makes the code more consistent. However, I do realize it doesn't fit all cases (i.e.; it would be tricky to get that one for Kafka), so it's OK too if that doesn't suit the change. Ultimately, I think it depends on who handles the batching (Camel or the implementation library) and also what modes are available (streaming, batching, reactive, etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
