christophd commented on code in PR #5346:
URL: https://github.com/apache/camel-k/pull/5346#discussion_r1559163225
##########
e2e/common/traits/health_test.go:
##########
@@ -362,6 +362,8 @@ func TestHealthTrait(t *testing.T) {
g.Eventually(IntegrationPodPhase(t, ctx, ns, name),
TestTimeoutLong).Should(Equal(corev1.PodRunning))
g.Eventually(IntegrationPhase(t, ctx, ns, name),
TestTimeoutShort).Should(Equal(v1.IntegrationPhaseRunning))
+ // Wait for the integration condition to become
ready=false and then check that it remains not ready for some time - fixes some
test flakiness
Review Comment:
What you say implies that the logic has changed recently and the E2E test
has become flaky due to that regression recently. I think the flakiness in this
test exists for quite some time since #4922 is reporting it already on Camel K
2.1 and it may be flaky even before that.
I am fine with working on the root cause and fix the condition status
setting but let's open a new issue now to track that in particular and let's
not keep the flaky test until this is tackled and completely resolved. In a few
weeks nobody will remember that the flakiness in this E2E test points to a
misbehavior that should be fixed. We need a new issue for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
