squakez commented on code in PR #5346:
URL: https://github.com/apache/camel-k/pull/5346#discussion_r1559146405
##########
e2e/common/traits/health_test.go:
##########
@@ -362,6 +362,8 @@ func TestHealthTrait(t *testing.T) {
g.Eventually(IntegrationPodPhase(t, ctx, ns, name),
TestTimeoutLong).Should(Equal(corev1.PodRunning))
g.Eventually(IntegrationPhase(t, ctx, ns, name),
TestTimeoutShort).Should(Equal(v1.IntegrationPhaseRunning))
+ // Wait for the integration condition to become
ready=false and then check that it remains not ready for some time - fixes some
test flakiness
Review Comment:
The point is that, according to your analysis, the test is not wrong. What's
wrong is the logic where we are blindly setting a value to something which
should not be. If we change this test we'd be promoting a wrong behavior
turning the bug into a feature. I am planning to retake the work of #5096 for
next release which may intersect with this problem. I'd suggest to either work
on the root cause or keep this on hold for the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
