claudio4j commented on code in PR #5275: URL: https://github.com/apache/camel-k/pull/5275#discussion_r1535767234
########## pkg/trait/knative.go: ########## @@ -70,7 +71,8 @@ func (t *knativeTrait) Configure(e *Environment) (bool, *TraitCondition, error) if e.Integration == nil { return false, nil, nil } - if !pointer.BoolDeref(t.Enabled, true) { Review Comment: I noticed the `NewIntegrationConditionUserDisabled` says the trait is explicitly disabled, so this sets the condition only when the user sets `enabled=false`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org