squakez commented on code in PR #5275:
URL: https://github.com/apache/camel-k/pull/5275#discussion_r1535621989
##########
pkg/trait/knative.go:
##########
@@ -70,7 +71,8 @@ func (t *knativeTrait) Configure(e *Environment) (bool,
*TraitCondition, error)
if e.Integration == nil {
return false, nil, nil
}
- if !pointer.BoolDeref(t.Enabled, true) {
Review Comment:
Why do you need this?
##########
pkg/trait/knative.go:
##########
@@ -81,6 +83,24 @@ func (t *knativeTrait) Configure(e *Environment) (bool,
*TraitCondition, error)
if err != nil {
return false, nil, err
}
+
+ if t.Enabled == nil {
Review Comment:
I think this is what the different `filterMetaItems` calls after this piece
of code do. At the end of the `configure` you should have all the knative
endpoints in the ChannelSources, ChannelSinks, ... variable. I think it is not
convenient calculating this twice. Maybe, you can check those resources after
they have been collected and do the needed logic accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
