lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2007195419

   > @lburgazzoli the problem is not the failure of the checks per se. As we've 
done in other PR, everything that may affect the Quarkus native has to be 
validated manually in order to make sure we don't introduce any regression. 
Please, have a look at this PR for instance: [#5234 
(comment)](https://github.com/apache/camel-k/pull/5234#issuecomment-1985493127)
   > 
   > If the folks have any problem running the native tests, you or I can run 
them and publish here the results, although, as suggested to some other 
contributor, it would be good to be able to do it on their own as it's should 
be a normal practice to do when doing some development. Running locally it is 
as easy as running any other integration test [1], it is only taking a bit of 
time more.
   > 
   
   I'm not complaining about having to run them locally, I'm just noticing the 
OSX build is almost always failing so I wonder what is the value of such test. 
Now I can run the test locally on my linux box and reporting them as ok but, 
what I've testes is not what has failed so people may spend time waiting and 
trying to find out why things are not working on OSX whereas it is an 
environment issue.
   
   > Beside, as mentioned in [2] my personal feeling is that these kind of 
changes would require some documentation and some rationale explanation as the 
users that will move from 2.2 to 2.3 will have the surprise of a multi 
deployment that may require them to adjust monitoring and other operational 
aspects. To me this is a breaking change, but if you want to proceed, at least 
it has to be clearly explained to the final users.
   > 
   
   I agree that we need some docs but since this PR is part of a larger issue 
and the rationale was briefly explained in 
https://github.com/apache/camel-k/issues/3397#issuecomment-1735525398, then I 
wonder if the doc could be something we do as a separate PR. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to