orpiske commented on code in PR #13403:
URL: https://github.com/apache/camel/pull/13403#discussion_r1516110769
##########
components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsConfiguration.java:
##########
@@ -620,7 +620,13 @@ private Object doSendToDestination(
// Check commit - avoid commit call within a JTA transaction.
if (session.getTransacted() &&
isSessionLocallyTransacted(session)) {
// Transacted session created by this template -> commit.
- JmsUtils.commitIfNecessary(session);
+ Assert.notNull(session, "Session must not be null");
+ try {
+ session.commit();
Review Comment:
IMHO, a more appropriate fix for this would involve creating an specific JMS
template for AMQP.
At a quick glace, it doesn't seem like the code easily allows this, so
probably would involve some refactoring on the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
