davsclaus commented on code in PR #13403:
URL: https://github.com/apache/camel/pull/13403#discussion_r1515896873
##########
components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsConfiguration.java:
##########
@@ -620,7 +620,13 @@ private Object doSendToDestination(
// Check commit - avoid commit call within a JTA transaction.
if (session.getTransacted() &&
isSessionLocallyTransacted(session)) {
// Transacted session created by this template -> commit.
- JmsUtils.commitIfNecessary(session);
+ Assert.notNull(session, "Session must not be null");
+ try {
+ session.commit();
Review Comment:
No camel-jms is for JMS and should be as-is that is battle tested with
spring-jms and all those kind of JMS brokers.
This ticket is about AMQP which is not JMS.
If there is a special need for camel-amqp in AMQP mode, then that must be
done specially in camel-amqp and not in general camel-jms.
Spring likely dont care about your AMQP as they use rabbitmq and its AMQP
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
