gansheer commented on code in PR #5151:
URL: https://github.com/apache/camel-k/pull/5151#discussion_r1487792970
##########
pkg/cmd/promote.go:
##########
@@ -468,6 +469,12 @@ func (o *promoteCmdOptions) editIntegration(it
*v1.Integration) *v1.Integration
dst.Spec.Traits.Container = &traitv1.ContainerTrait{}
}
dst.Spec.Traits.Container.Image = contImage
+ if dst.Spec.Traits.JVM == nil {
Review Comment:
It is not a flacky test in this case, the promote command run the "promoted"
integration with the trait `Container.Image`, so it becomes an external kit and
does not start correctly. Since the trait was not explicilty set in the
original integration, we are relying on default behavior, which will be
different for original and promoted integration. This aims to fix this issue.
The alternative would be to add support for the traits on the comand options
or add the copy of the integration kit created for the image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
