squakez commented on code in PR #5151:
URL: https://github.com/apache/camel-k/pull/5151#discussion_r1487753213
##########
pkg/cmd/promote.go:
##########
@@ -468,6 +469,12 @@ func (o *promoteCmdOptions) editIntegration(it
*v1.Integration) *v1.Integration
dst.Spec.Traits.Container = &traitv1.ContainerTrait{}
}
dst.Spec.Traits.Container.Image = contImage
+ if dst.Spec.Traits.JVM == nil {
Review Comment:
I don't think we need this check. We know the promote tests are kind of
flaky, no need to add anything in the command IMO. The container has to be
initialized because it could raise a nil exception, but not the JVM trait, for
which, we must keep the default setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
