squakez commented on code in PR #4968: URL: https://github.com/apache/camel-k/pull/4968#discussion_r1418522636
########## docs/modules/traits/pages/builder.adoc: ########## @@ -101,3 +101,19 @@ Syntax: [configmap\|secret]:name[/key], where name represents the resource name, |=== // End of autogenerated code - DO NOT EDIT! (configuration) + +== Node Selectors + +With this trait you will also be able to define node selectors for the `builder`` pod when using the `pod`` build strategy. Review Comment: ```suggestion With this trait you will also be able to define node selectors for the `builder` pod when using the `pod` build strategy. ``` ########## docs/modules/traits/pages/builder.adoc: ########## @@ -101,3 +101,19 @@ Syntax: [configmap\|secret]:name[/key], where name represents the resource name, |=== // End of autogenerated code - DO NOT EDIT! (configuration) + +== Node Selectors + +With this trait you will also be able to define node selectors for the `builder`` pod when using the `pod`` build strategy. +Here is a simple example: + +.template.yaml Review Comment: As traits are very handy with CLI, it would be good to add also the notation required by `kamel`. For example `kamel run xyz -t builder.nodeSelector...`. ########## docs/modules/traits/pages/builder.adoc: ########## @@ -101,3 +101,19 @@ Syntax: [configmap\|secret]:name[/key], where name represents the resource name, |=== // End of autogenerated code - DO NOT EDIT! (configuration) + +== Node Selectors + +With this trait you will also be able to define node selectors for the `builder`` pod when using the `pod`` build strategy. +Here is a simple example: + +.template.yaml +[source,yaml] +---- + traits: + builder: + nodeSelector: + size: large +---- + +The `builder` pod will be created with a node selector that allows it to run only on nodes where the `size`` label is equal to `large`.` Review Comment: ```suggestion The `builder` pod will be created with a node selector that allows it to run only on nodes where the `size` label is equal to `large`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
