squakez commented on PR #4968: URL: https://github.com/apache/camel-k/pull/4968#issuecomment-1841262050
Cool stuff. Thanks for contributing. I'll give a deeper look on Thursday. In the while you need to run `make generate` to regen CRDs and trait documentation and it could be good to add some extra documentation to explain how the trait has to be specified with a simple example. You can add some code after this line https://github.com/apache/camel-k/blob/5aed911f5ec60a253b72ddf9110df99c97dd36ed/docs/modules/traits/pages/builder.adoc?plain=1#L103 and follow the example we provide for instance in other traits, ie, https://github.com/apache/camel-k/blob/5aed911f5ec60a253b72ddf9110df99c97dd36ed/docs/modules/traits/pages/pod.adoc?plain=1#L49 Feel free to have a look to unit test as well. It would be good to cover a basic scenario, here a reference as well https://github.com/apache/camel-k/blob/5aed911f5ec60a253b72ddf9110df99c97dd36ed/pkg/trait/builder_test.go#L290 I just saw the build failed because we have many pending PRs running simultaneously. @christophd or @claudio4j please, re-trigger the checks tomorrow when there is no high PR traffic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
