gansheer commented on code in PR #4315:
URL: https://github.com/apache/camel-k/pull/4315#discussion_r1198721664
##########
pkg/builder/quarkus.go:
##########
@@ -208,6 +208,48 @@ func GenerateQuarkusProjectCommon(runtimeVersion string,
quarkusVersion string,
},
},
},
+ maven.Plugin{
+ GroupID: "com.google.cloud.tools",
+ ArtifactID: "jib-maven-plugin",
+ Version: "3.3.1",
+ Dependencies: []maven.Dependency{
+ {
+ GroupID: "com.google.cloud.tools",
+ ArtifactID:
"jib-layer-filter-extension-maven",
+ Version: "0.3.0",
+ },
+ },
+ Configuration: v1.PluginConfiguration{
+ Container: v1.Container{
+ Entrypoint: "INHERIT",
+ Args: v1.Args{
+ Arg: "jshell",
+ },
+ },
+ AllowInsecureRegistries: "true",
+ ExtraDirectories: v1.ExtraDirectories{
+ Paths: v1.Paths{
+ Path: v1.Path{
+ From: "../context",
+ Into: "/deployments",
+ },
+ },
+ },
+ PluginExtensions: v1.PluginExtensions{
+ PluginExtension: v1.PluginExtension{
+ Implementation:
"com.google.cloud.tools.jib.maven.extension.layerfilter.JibLayerFilterExtension",
+ Configuration:
v1.PluginExtensionConfiguration{
+ Implementation:
"com.google.cloud.tools.jib.maven.extension.layerfilter.Configuration",
+ Filters: v1.Filters{
+ Filter:
v1.Filter{
+ Glob:
"/app/**",
Review Comment:
In short yes we have a single layer created by the configuration:
```
ExtraDirectories: v1.ExtraDirectories{
Paths: v1.Paths{
Path: v1.Path{
From: "../context",
Into: "/deployments",
},
},
},
```
The Filter code remove the default layers created by the google jib plugin
done into the `app` folder by default.
I agree with you that the quarkus jib extension creates good layers
according to the quarkus build, but sadly it can't make any incremental build.
If you know a way to have actual incremental layers please don't hesitate. As
it is the fact that the quarkus extension does not offer the possibility to use
another folder that the default 'target' creates 2 full layers for libs that
double the size of these dependencies in the final image.
I will see if I can make a better set of layers with the `ExtraDirectories`
plugin configuration, that is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
