gansheer commented on code in PR #4315:
URL: https://github.com/apache/camel-k/pull/4315#discussion_r1183830963
##########
pkg/util/maven/maven_command.go:
##########
@@ -240,6 +245,11 @@ func generateProjectStructure(context Context, project
Project) error {
return nil
}
+// Create a MAVEN_CONTEXT file containing all arguments for a maven command
+func generateMavenContext(context Context, args []string) error {
+ return util.WriteToFile(filepath.Join(context.Path, "MAVEN_CONTEXT"),
strings.Join(args, " "))
Review Comment:
In short : I write into a /tmp/kit-xxxxxx-yyyyy/maven/MAVEN_CONTEXT file
all the parameters of the build maven command, and then I re-use them in the
jib task. The way I see it is that we are doing maven command in both case, so
any maven repository, or any other configuration used in the build context
should work in the jib task.
But that's clearly the part that needs to be refined. I suspect I write too
many arguments in the file. To illustrate this for better understanding that is
why I need to remove the goal (`package`) in the jib task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
