[GitHub] [camel] rangoy commented on a diff in pull request #9451: [CAMEL-19100] Fixes lost dataChangeFilterTrigger in camel-milo

[via GitHub]

rangoy commented on code in PR #9451:
URL: https://github.com/apache/camel/pull/9451#discussion_r1120248320


##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MonitorFilterConfiguration.java:
##########
@@ -80,7 +80,9 @@ public MonitoringFilter createMonitoringFilter() {
         switch (monitorFilterType) {
             default:
                 return new DataChangeFilter(
-                        DataChangeTrigger.StatusValueTimestamp, 
this.getDataChangeFilterDeadbandType(),
+                        this.dataChangeFilterTrigger != null
+                                ? this.dataChangeFilterTrigger : 
DataChangeTrigger.StatusValueTimestamp,

Review Comment:
   Good point. I did not pay attenation to that the filter had a default 
different from what was actually applied here. 
   
   I've updated the pullrequest to use the old effective default value 
(StatusValueTimestamp)
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org