essobedo commented on code in PR #9451:
URL: https://github.com/apache/camel/pull/9451#discussion_r1120231531
##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MonitorFilterConfiguration.java:
##########
@@ -80,7 +80,9 @@ public MonitoringFilter createMonitoringFilter() {
switch (monitorFilterType) {
default:
return new DataChangeFilter(
- DataChangeTrigger.StatusValueTimestamp,
this.getDataChangeFilterDeadbandType(),
+ this.dataChangeFilterTrigger != null
+ ? this.dataChangeFilterTrigger :
DataChangeTrigger.StatusValueTimestamp,
Review Comment:
Warning this is a behavior change, as far as I can see the current default
value is
[`DataChangeTrigger.StatusValue`](https://github.com/apache/camel/blob/c1a8be35640603c35160aba07d715c3cd3878af0/components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MonitorFilterConfiguration.java#L41)
whereas at runtime it used `DataChangeTrigger.StatusValueTimestamp`. Maybe
should change the default value to `DataChangeTrigger.StatusValueTimestamp` and
use `dataChangeFilterTrigger` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
