orpiske commented on code in PR #9339:
URL: https://github.com/apache/camel/pull/9339#discussion_r1104791396
##########
components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java:
##########
@@ -239,7 +240,7 @@ public void updateState(EntryInfo.CachedEntryInfo
entryInfo, LogEntry.EntryState
Trying to update a persisted entry here is not acceptable
*/
- assert layerInfo != null;
+ ObjectHelper.notNull(layerInfo, "layerInfo");
Review Comment:
The impact of `ObjectHelper.nonNull` is pretty small. Almost close to none,
but still a bit faster.
```
AssertTest.benchmarkAssert avgt 10 183.115 ± 0.844 us/op
AssertTest.benchmarkHelper avgt 10 186.937 ± 0.779 us/op
```
Of all the items I commented, this one is the only one which is a big -1
from me. The log writer adds a small bit of latency on the Resume process due
to the I/O, so every bit of performance that can be saved here, is important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
