[GitHub] [camel] bvahdat commented on a diff in pull request #9339: avoid java assert keyword as disabled per default

[via GitHub]

bvahdat commented on code in PR #9339:
URL: https://github.com/apache/camel/pull/9339#discussion_r1104682355


##########
components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java:
##########
@@ -239,7 +240,7 @@ public void updateState(EntryInfo.CachedEntryInfo 
entryInfo, LogEntry.EntryState
 
          Trying to update a persisted entry here is not acceptable
          */
-        assert layerInfo != null;
+        ObjectHelper.notNull(layerInfo, "layerInfo");

Review Comment:
   > impacts the performance of the log write
   
   Not sure if a null check through `ObjectHelper.notNull`will have any 
reasonable performance impact, or do we maybe have any benchmark for that which 
proves it otherwise?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org