[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4404: testing defaultCredentialProvider with local stack #440

[via GitHub]

zbendhiba commented on code in PR #4404:
URL: https://github.com/apache/camel-quarkus/pull/4404#discussion_r1086734773


##########
integration-test-groups/aws2/aws2-cw/src/main/java/org/apache/camel/quarkus/component/aws2/cw/it/Aws2CwResource.java:
##########
@@ -97,18 +104,30 @@ public Response postMap(
                     return val;
                 }));
         try {
+            if (defaultCredentialsProvider && setCredentials) {
+                System.setProperty("aws.accessKeyId",
+                        
ConfigProvider.getConfig().getValue("camel.component.aws2-cw.access-key", 
String.class));
+                System.setProperty("aws.secretAccessKey",
+                        
ConfigProvider.getConfig().getValue("camel.component.aws2-cw.secret-key", 
String.class));

Review Comment:
   @JiriOndrusek  Could you please explain why we would need to do this?
   ```
   System.setProperty("aws.secretAccessKey",
                           
ConfigProvider.getConfig().getValue("camel.component.aws2-cw.secret-key", 
String.class));
   ```
   
   - What is `ConfigProvider.getConfig()` for?
   - Is it possible to set the value with `ConfigProvider` instead of 
`System.setProperty` ?
   
   I would love to have the explanation of why we need to do this and possibly 
also have it commented out in the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org