JiriOndrusek opened a new pull request, #4404: URL: https://github.com/apache/camel-quarkus/pull/4404
fixes https://github.com/apache/camel-quarkus/issues/4401 Proposal of testing [STATIC CREDENTIALS VS DEFAULT CREDENTIAL PROVIDER](https://camel.apache.org/components/3.18.x/aws2-cw-component.html#_static_credentials_vs_default_credential_provider) This PR implements the testing for cw only. @jamesnetherton @aldettinger @ppalaga what do you think about it? main ideas: - The test could be executed only with mock backend on system without defaulCredentialsProvider - covered by `Aws2DefaultCredentialsProviderAvailabilityCondition` - The test set system.properties with localstack authentication and removes them afterwards - It should be possible to add similar test method for other aws2 extension tests (without duplicated code) dissadvantage - if system defines defaultCredentialsProvider (e.g, aiming to real service), test is skipped -> which may hide an error <!-- Uncomment and fill this section if your PR is not trivial [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes. [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #. [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough. [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea. [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request. [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
