lburgazzoli commented on code in PR #3480:
URL: https://github.com/apache/camel-k/pull/3480#discussion_r930673914
##########
pkg/trait/util.go:
##########
@@ -320,3 +321,26 @@ func getBuilderTask(tasks []v1.Task) *v1.BuilderTask {
}
return nil
}
+
+// Equals return if traits set using annotations have changed.
+func Equals(oldObject metav1.Object, newObject metav1.Object) bool {
Review Comment:
Yes I think the current solution is suboptimal but with my outdated
knowledge of the codebase I tried to be conservative.
I think the proper solution would be to always reason on a synthetic view of
the trait as in fact we may have cases where two resources have the same traits
but defined in a different way.
I'll try to work on something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
