tadayosi commented on code in PR #3480:
URL: https://github.com/apache/camel-k/pull/3480#discussion_r930581435
##########
pkg/trait/util.go:
##########
@@ -320,3 +321,26 @@ func getBuilderTask(tasks []v1.Task) *v1.BuilderTask {
}
return nil
}
+
+// Equals return if traits set using annotations have changed.
+func Equals(oldObject metav1.Object, newObject metav1.Object) bool {
Review Comment:
I first saw the function name and misunderstood it as comparing both
annotations and spec.traits. It's only when I stared at the arg types that I
understood the correct intent.
Apart from the function name, is it not needed to actually compare the
traits under specs as well for where the func is invoked? Is it not necessary
because changes to traits under spec are handled in a different mechanics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
