zhfeng commented on code in PR #7727:
URL: https://github.com/apache/camel/pull/7727#discussion_r891146198
##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java:
##########
@@ -579,6 +579,10 @@ private void createDownloadLink(Exchange exchange) {
.build();
PresignedGetObjectRequest presignedGetObjectRequest =
presigner.presignGetObject(getObjectPresignRequest);
+ if (!presignedGetObjectRequest.isBrowserExecutable()) {
Review Comment:
I'd like to add two headers
- `DOWNLOAD_LINK_HTTP_REQUEST_HEADERS` with
`presignedGetObjectRequest.httpRequest().headers()`
- `DOWNLOAD_LINK_SIGNED_PAYLOAD` with
`presignedGetObjectRequest.signedPayload().asUtf8String()` if present
I just find that signed payload could be read as `String` so it should be
fine to be added into message headers. And if the users really need to enable
`checksum validation` when getting the dowonload link, it is their
repsonsibleity to get these two from the message headers and add them into the
http request for downloading the file. We can add this information as a `NOTE`
in our aws2-s3.adoc
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
