davsclaus commented on code in PR #7727:
URL: https://github.com/apache/camel/pull/7727#discussion_r890989750
##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java:
##########
@@ -579,6 +579,10 @@ private void createDownloadLink(Exchange exchange) {
.build();
PresignedGetObjectRequest presignedGetObjectRequest =
presigner.presignGetObject(getObjectPresignRequest);
+ if (!presignedGetObjectRequest.isBrowserExecutable()) {
Review Comment:
and if its not browser compatible then the url cannot really be used to
download from a brwoser, and you need all this workaround code you pointed to?
And because the presigner is closed in camel, then I would not think you can
return a header with an input stream as the stream would then be closed
So maybe we do
1) return nothing as a download url is not possible
2) add option to allow to eager download if not browser compabile, but this
will then return a blob instead of an url and the returned data can be very big
if the s3 file is very big (this can be confusing as either you get a url or a
big payload)
3) something else ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
