squakez commented on a change in pull request #3008:
URL: https://github.com/apache/camel-k/pull/3008#discussion_r804736957
##########
File path: pkg/builder/image.go
##########
@@ -120,7 +120,7 @@ func jvmDockerfile(ctx *builderContext) error {
}
func incrementalImageContext(ctx *builderContext) error {
- if ctx.Build.BaseImage != "" {
+ if ctx.Build.BaseImage != "" && ctx.Build.BaseImage !=
defaults.BaseImage() {
Review comment:
True. I fail to understand this check meaning then and how it worked
before the last refactoring. The `ctx.Build.BaseImage` will always be `!= ""`
because, at minimum it is filled with the default base image, reason why it is
not working. Any help appreciated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
