astefanutti commented on a change in pull request #3008:
URL: https://github.com/apache/camel-k/pull/3008#discussion_r804668099
##########
File path: pkg/builder/image.go
##########
@@ -120,7 +120,7 @@ func jvmDockerfile(ctx *builderContext) error {
}
func incrementalImageContext(ctx *builderContext) error {
- if ctx.Build.BaseImage != "" {
+ if ctx.Build.BaseImage != "" && ctx.Build.BaseImage !=
defaults.BaseImage() {
Review comment:
I think it's still an issue when the base image set on the
IntegrationPlatform that's been used to initialise the Build base image is
different than `default.BaseImage`?
##########
File path: pkg/builder/image.go
##########
@@ -120,7 +120,7 @@ func jvmDockerfile(ctx *builderContext) error {
}
func incrementalImageContext(ctx *builderContext) error {
- if ctx.Build.BaseImage != "" {
+ if ctx.Build.BaseImage != "" && ctx.Build.BaseImage !=
defaults.BaseImage() {
Review comment:
I think it's still an issue when the base image set on the
IntegrationPlatform that's been used to initialise the Build base image is
different than `default.BaseImage()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
