bvfalcon commented on a change in pull request #6726:
URL: https://github.com/apache/camel/pull/6726#discussion_r783910941
##########
File path:
components/camel-google/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/GoogleMailConfiguration.java
##########
@@ -124,4 +133,38 @@ public void setApplicationName(String applicationName) {
this.applicationName = applicationName;
}
+ public String getFilename() {
+ return filename;
+ }
+
+ /**
+ * Filename "*.json" with credentials for Service account
+ */
+ public void setFilename(String filename) {
Review comment:
> what the makeClient expect
makeClient , exactly
_com.google.api.client.googleapis.auth.oauth2.GoogleCredential.fromStream(InputStream)_
makes good job with InputStream: he parses it and [**closes**
it](https://github.com/googleapis/google-api-java-client/blob/main/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java#L231).
This is the reason, why we transform String into InputStream jst here: in
another place we must close/cutch errors self.
I would prefer stay InputStream processing as it is now, but of course if
you think it is not a strong argument, I make it the way you proposed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
