oscerd commented on a change in pull request #6726:
URL: https://github.com/apache/camel/pull/6726#discussion_r783281114
##########
File path: components/camel-google/camel-google-mail/pom.xml
##########
@@ -38,6 +38,8 @@
<componentPackage>org.apache.camel.component.google.mail</componentPackage>
<outPackage>org.apache.camel.component.google.mail.internal</outPackage>
<camel.osgi.private.pkg>org.apache.camel.component.google.mail.internal</camel.osgi.private.pkg>
+ <google-api-client-version>1.32.1</google-api-client-version>
Review comment:
This needs to be parent/pom
##########
File path:
components/camel-google/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/GoogleMailConfiguration.java
##########
@@ -124,4 +133,38 @@ public void setApplicationName(String applicationName) {
this.applicationName = applicationName;
}
+ public String getFilename() {
+ return filename;
+ }
+
+ /**
+ * Filename "*.json" with credentials for Service account
+ */
+ public void setFilename(String filename) {
Review comment:
This filename option should use the usual approach we have in other
component so it should be resolved from classpath, file, http etc. You have
multiple examples in the codebase
##########
File path: components/camel-google/camel-google-mail/pom.xml
##########
@@ -83,6 +85,11 @@
<artifactId>google-api-services-gmail</artifactId>
<version>${google-api-services-mail-version}</version>
</dependency>
+ <dependency>
Review comment:
+1
##########
File path: components/camel-google/camel-google-mail/pom.xml
##########
@@ -38,6 +38,8 @@
<componentPackage>org.apache.camel.component.google.mail</componentPackage>
<outPackage>org.apache.camel.component.google.mail.internal</outPackage>
<camel.osgi.private.pkg>org.apache.camel.component.google.mail.internal</camel.osgi.private.pkg>
+ <google-api-client-version>1.32.1</google-api-client-version>
+
<google-api-services-mail-version>v1-rev20211108-1.32.1</google-api-services-mail-version>
Review comment:
This needs to be parent/pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
