vsokolov00 commented on a change in pull request #2656:
URL: https://github.com/apache/camel-k/pull/2656#discussion_r714853664
##########
File path: pkg/cmd/dump.go
##########
@@ -173,13 +174,13 @@ func dumpNamespace(ctx context.Context, c client.Client,
ns string, out *os.File
return nil
}
-func dumpConditions(prefix string, conditions []v1.PodCondition, out *os.File)
{
+func dumpConditions(prefix string, conditions []v1.PodCondition, out
io.Writer) {
Review comment:
[Here](https://github.com/apache/camel-k/blob/2be1a0a450413be14939deb8a623ddd5cc01aef8/pkg/cmd/dump.go#L160)
io.Writer will be passed to this function because
[this](https://github.com/apache/camel-k/blob/2be1a0a450413be14939deb8a623ddd5cc01aef8/pkg/cmd/dump.go#L76)
function definition was also changed due to the fact that dump output could be
redirected to the
[os.File](https://github.com/apache/camel-k/blob/2be1a0a450413be14939deb8a623ddd5cc01aef8/pkg/cmd/dump.go#L62-L72)
also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
