squakez commented on a change in pull request #2656:
URL: https://github.com/apache/camel-k/pull/2656#discussion_r714759493
##########
File path: pkg/cmd/describe_platform.go
##########
@@ -60,14 +60,14 @@ type describePlatformCommandOptions struct {
*RootCmdOptions
}
-func (command *describePlatformCommandOptions) validate(args []string) error {
+func (command *describePlatformCommandOptions) validate(_ *cobra.Command, args
[]string) error {
Review comment:
Any reason why we are changing the method? I mean, we don't use that
input variable after all. I guess it's to have the same structure in all
method, but it's something that is not really required.
##########
File path: pkg/cmd/dump.go
##########
@@ -173,13 +174,13 @@ func dumpNamespace(ctx context.Context, c client.Client,
ns string, out *os.File
return nil
}
-func dumpConditions(prefix string, conditions []v1.PodCondition, out *os.File)
{
+func dumpConditions(prefix string, conditions []v1.PodCondition, out
io.Writer) {
Review comment:
Any reason to change this? I don't see any of the method caller changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
