astefanutti commented on a change in pull request #2392: URL: https://github.com/apache/camel-k/pull/2392#discussion_r649723263
########## File path: docs/modules/ROOT/pages/contributing/developers.adoc ########## @@ -109,6 +109,24 @@ After you log in into your cluster, you can run the following command to execute make test-integration ---- +[NOTE] +==== +To speed up integration testing locally, you may use a https://github.com/sonatype/docker-nexus3[Nexus Repository Manager] for Maven repository mirror. + +You can set the environment variable `TEST_EABLE_NEXUS=true` to enable the usage of Nexus mirror in e2e testing. If `TEST_EABLE_NEXUS` is set, e2e tests will try to discover an Nexus instance as `nexus` service in `nexus` namespace and if it is found they will use it as the Maven repository mirror for the `camel-k` platform under test. Review comment: `TEST_EABLE_NEXUS` -> `TEST_ENABLE_NEXUS` ########## File path: docs/modules/ROOT/pages/contributing/developers.adoc ########## @@ -109,6 +109,24 @@ After you log in into your cluster, you can run the following command to execute make test-integration ---- +[NOTE] Review comment: There is a page dedicated to e2e testing, that may be a better location for documenting this: https://camel.apache.org/camel-k/latest/contributing/e2e.html. ########## File path: docs/modules/ROOT/pages/contributing/developers.adoc ########## @@ -85,29 +85,14 @@ make STAGING_IMAGE_NAME='docker.io/myrepo/camel-k' images-push-staging == Testing Unit tests are executed automatically as part of the build. They use the standard go testing framework. +The **convention** used in this repo is to name tests `xxx_test.go`. Review comment: I think it's a convention from Golang, that relies on it for `go test`, rather than a convention from this repository. I'd suggest to remove it. ########## File path: docs/modules/ROOT/pages/contributing/developers.adoc ########## @@ -85,29 +85,14 @@ make STAGING_IMAGE_NAME='docker.io/myrepo/camel-k' images-push-staging == Testing Unit tests are executed automatically as part of the build. They use the standard go testing framework. +The **convention** used in this repo is to name tests `xxx_test.go`. Review comment: Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
