tadayosi commented on a change in pull request #2392:
URL: https://github.com/apache/camel-k/pull/2392#discussion_r649750515
##########
File path: docs/modules/ROOT/pages/contributing/developers.adoc
##########
@@ -109,6 +109,24 @@ After you log in into your cluster, you can run the
following command to execute
make test-integration
----
+[NOTE]
Review comment:
Yeah but the existing e2e doc doesn't talk about `make test-integration`
there. At this moment, doc on e2e testing is split into two places. I agree
that we need to consolidate the doc and e2e.adoc is the right place.
##########
File path: docs/modules/ROOT/pages/contributing/developers.adoc
##########
@@ -109,6 +109,24 @@ After you log in into your cluster, you can run the
following command to execute
make test-integration
----
+[NOTE]
+====
+To speed up integration testing locally, you may use a
https://github.com/sonatype/docker-nexus3[Nexus Repository Manager] for Maven
repository mirror.
+
+You can set the environment variable `TEST_EABLE_NEXUS=true` to enable the
usage of Nexus mirror in e2e testing. If `TEST_EABLE_NEXUS` is set, e2e tests
will try to discover an Nexus instance as `nexus` service in `nexus` namespace
and if it is found they will use it as the Maven repository mirror for the
`camel-k` platform under test.
Review comment:
Thanks, I'll correct it.
##########
File path: docs/modules/ROOT/pages/contributing/developers.adoc
##########
@@ -109,6 +109,24 @@ After you log in into your cluster, you can run the
following command to execute
make test-integration
----
+[NOTE]
Review comment:
I will take this opportunity to consolidate the doc in this pull req.
Let me change the doc part as well.
##########
File path: docs/modules/ROOT/pages/contributing/developers.adoc
##########
@@ -85,29 +85,14 @@ make STAGING_IMAGE_NAME='docker.io/myrepo/camel-k'
images-push-staging
== Testing
Unit tests are executed automatically as part of the build. They use the
standard go testing framework.
+The **convention** used in this repo is to name tests `xxx_test.go`.
Review comment:
Cleaned up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
