ffang commented on pull request #2635:
URL: https://github.com/apache/camel-quarkus/pull/2635#issuecomment-845112321


   > Thanks, the test coverage is highly appreciated. Except for the two minor 
comments inline, could you please move the Jackson XML related stuff to 
separate test classes (JacksonXmlTest and JacksonXmlIT) and to a separate 
package (e.g. `org.apache.camel.quarkus.component.dataformats.jackson.xml`) in 
the test app? That would make it easier for the future readers to understand 
which parts are testing which extensions.
   
   Thanks for the feedback! Will revise accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to