davsclaus commented on a change in pull request #5370:
URL: https://github.com/apache/camel/pull/5370#discussion_r613465975



##########
File path: 
core/camel-support/src/main/java/org/apache/camel/support/AbstractExchange.java
##########
@@ -189,7 +189,15 @@ public Exchange copy() {
 
     @SuppressWarnings("unchecked")
     private void safeCopyProperties(Map<String, Object> source, Map<String, 
Object> target) {
-        target.putAll(source);
+        source.entrySet().stream().forEach(entry -> {

Review comment:
       Instead of doing this expensive check always, then find out some way for 
zipkin et all to turn on a flag on the exchange (via ExtendedExchange) to tell 
it that it should do deep clone safe copy mode, then this is only in use when 
you use these special zipkin components.
   
   Or instead of storing the zipkin state as exchange property, store it on 
some zipkin bean, that handles this and stores the data per exchange id or 
something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to