samratdhillon commented on a change in pull request #5370:
URL: https://github.com/apache/camel/pull/5370#discussion_r613453034
##########
File path:
core/camel-support/src/main/java/org/apache/camel/support/AbstractExchange.java
##########
@@ -189,7 +189,15 @@ public Exchange copy() {
@SuppressWarnings("unchecked")
private void safeCopyProperties(Map<String, Object> source, Map<String,
Object> target) {
- target.putAll(source);
+ source.entrySet().stream().forEach(entry -> {
Review comment:
@davsclaus Are you suggesting to totally avoid changes in core, or avoid
these specific changes in core? I initially did come up with another approach
for camel-zipkin but it is far more complicated and honestly does not address
the real problem.
The span problem I am pretty sure exists in camel opentracing and
opentelemetry as well because both of them use camel-tracing and if you look at
[ActiveSpanManager](https://github.com/apache/camel/blob/master/components/camel-tracing/src/main/java/org/apache/camel/tracing/ActiveSpanManager.java)
it also uses Exchange property mechanism to set ACTIVE_SPAN_PROPERTY which
would get corrupted when using parallelProcessing with multicast.
My suggested approach would easily fix issues in opentracing and
opentelemetry as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
