oscerd commented on a change in pull request #4876:
URL: https://github.com/apache/camel/pull/4876#discussion_r556506921
##########
File path:
components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConsumer.java
##########
@@ -59,19 +70,21 @@ public GoogleCalendarStreamEndpoint getEndpoint() {
@Override
protected int poll() throws Exception {
- com.google.api.services.calendar.Calendar.Events.List request
- =
getClient().events().list(getConfiguration().getCalendarId()).setOrderBy("updated");
+ Calendar.Events.List request =
getClient().events().list(getConfiguration().getCalendarId());
if (ObjectHelper.isNotEmpty(getConfiguration().getQuery())) {
Review comment:
Then instead of doing this check here in the poll, check if syncFlow is
true and query is set in the endpoint consumer creation and fail there. Don't
use Precondition, is just another class that will change in the future and
we'll have to align, you just need to check a boolean value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
