jmerljak commented on a change in pull request #4876:
URL: https://github.com/apache/camel/pull/4876#discussion_r556504440
##########
File path:
components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConsumer.java
##########
@@ -59,19 +70,21 @@ public GoogleCalendarStreamEndpoint getEndpoint() {
@Override
protected int poll() throws Exception {
- com.google.api.services.calendar.Calendar.Events.List request
- =
getClient().events().list(getConfiguration().getCalendarId()).setOrderBy("updated");
+ Calendar.Events.List request =
getClient().events().list(getConfiguration().getCalendarId());
if (ObjectHelper.isNotEmpty(getConfiguration().getQuery())) {
Review comment:
I was referring to
https://github.com/apache/camel/blob/master/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/GoogleCalendarEndpoint.java#L66
where an exception is thrown when incompatible option is set. Invalid
configuration results in request failures, so it's better to fail fast.
Moreover, `syncFlow` may not be empty, it just shouldn't be set to `true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
