[GitHub] [camel] rmannibucau commented on a change in pull request #4562: [CAMEL-15725] setting up basic OSGi-CDI metadata in the manifest

[GitBox]

rmannibucau commented on a change in pull request #4562:
URL: https://github.com/apache/camel/pull/4562#discussion_r521307998



##########
File path: components/camel-cdi/pom.xml
##########
@@ -37,10 +37,37 @@
         <label>java</label>
         <title>CDI</title>
 
+        <camel.osgi.provide.capability>
+            osgi.cdi.extension;osgi.cdi.extension="org.apache.camel.cdi";
+                version:Version="${camel.osgi.version}";
+                
aries.cdi.extension.bean.classes:List&lt;String&gt;="org.apache.camel.cdi.CdiCamelFactory,org.apache.camel.cdi.CdiEventComponent";
+                    
uses:="javax.annotation,javax.enterprise.event,javax.enterprise.inject.spi",
+            
osgi.service;objectClass:List&lt;String&gt;="javax.enterprise.inject.spi.Extension",
+                
osgi.service;objectClass:List&lt;String&gt;="javax.enterprise.inject.spi.Extension";
+                    uses:="javax.enterprise.inject.spi";
+                    osgi.cdi.extension="org.apache.camel.cdi";
+                service.scope=prototype;service.vendor="Apache Software 
Foundation";
+                version:Version="${camel.osgi.version}";
+                effective:=active,
+            
osgi.serviceloader;osgi.serviceloader="javax.enterprise.inject.spi.Extension";
+                register:="org.apache.camel.cdi.CdiCamelExtension";
+                    uses:="javax.enterprise.inject.spi";
+                    osgi.cdi.extension="org.apache.camel.cdi";
+                    service.scope=prototype;
+                    service.vendor="Apache Software Foundation";
+                version:Version="${camel.osgi.version}"
+        </camel.osgi.provide.capability>
+        <camel.osgi.require.capability>
+            
osgi.extender;filter:="(&amp;(osgi.extender=osgi.cdi)(version>=1.0.0)(!(version>=2.0.0)))",

Review comment:
       You can make it generated with bnd 5 using osgi.annotations (which is 
fine for camel since scope would be provided) but not sure it is better ;).
   At the end I don't care much how but I'd like to be able to use camel-cdi 
with osgi-cdi :).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org