[GitHub] [camel] davsclaus commented on a change in pull request #4562: [CAMEL-15725] setting up basic OSGi-CDI metadata in the manifest

[GitBox]

davsclaus commented on a change in pull request #4562:
URL: https://github.com/apache/camel/pull/4562#discussion_r521256327



##########
File path: components/camel-cdi/pom.xml
##########
@@ -37,10 +37,37 @@
         <label>java</label>
         <title>CDI</title>
 
+        <camel.osgi.provide.capability>
+            osgi.cdi.extension;osgi.cdi.extension="org.apache.camel.cdi";
+                version:Version="${camel.osgi.version}";
+                
aries.cdi.extension.bean.classes:List&lt;String&gt;="org.apache.camel.cdi.CdiCamelFactory,org.apache.camel.cdi.CdiEventComponent";
+                    
uses:="javax.annotation,javax.enterprise.event,javax.enterprise.inject.spi",
+            
osgi.service;objectClass:List&lt;String&gt;="javax.enterprise.inject.spi.Extension",
+                
osgi.service;objectClass:List&lt;String&gt;="javax.enterprise.inject.spi.Extension";
+                    uses:="javax.enterprise.inject.spi";
+                    osgi.cdi.extension="org.apache.camel.cdi";
+                service.scope=prototype;service.vendor="Apache Software 
Foundation";
+                version:Version="${camel.osgi.version}";
+                effective:=active,
+            
osgi.serviceloader;osgi.serviceloader="javax.enterprise.inject.spi.Extension";
+                register:="org.apache.camel.cdi.CdiCamelExtension";
+                    uses:="javax.enterprise.inject.spi";
+                    osgi.cdi.extension="org.apache.camel.cdi";
+                    service.scope=prototype;
+                    service.vendor="Apache Software Foundation";
+                version:Version="${camel.osgi.version}"
+        </camel.osgi.provide.capability>
+        <camel.osgi.require.capability>
+            
osgi.extender;filter:="(&amp;(osgi.extender=osgi.cdi)(version>=1.0.0)(!(version>=2.0.0)))",

Review comment:
       OSGi is lovely ;)
   
   All that osgi metadata above is written by hand and can get out of cruft as 
its woodo for most people what has to be there. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org