silundong commented on code in PR #4840:
URL: https://github.com/apache/calcite/pull/4840#discussion_r3007920781
##########
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##########
@@ -4752,6 +4759,17 @@ public ImmutableBitSet build() {
}
return super.visitCall(call);
}
+
+ @Override public Void visitSubQuery(RexSubQuery subQuery) {
Review Comment:
Just to avoid any misunderstanding, let me explain again. For example:
There is a `Filter(condition=[subquery], variablesSet=[cor2])`, and the
subquery has two free variables: `cor2.id` and `cor1.name` (assume that `cor1`
belongs to an outer scope). If we use `InputFinder` to analyze the `Filter`
condition, `InputFinder` should record the index of `cor2.id` and ignore
`cor1.name`.
As I mentioned below, similar logic should also apply to
`RexInputConverter.visitSubQuery`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
