yashlimbad commented on PR #4840: URL: https://github.com/apache/calcite/pull/4840#issuecomment-4152119392
> Pushing down correlated subqueries may carry risks; sorry I didn't provide concrete cases. The logic here is indeed complex. Perhaps follow the logic for handling the top-level `Filter` in `FilterJoinRule`—i.e., not pushing down correlated subqueries—would be a good option. the subquery is inside Join condition, not inside filter on top of join. and decorrelating join's condition is harder and can complicate resulting tree sometime. on the other hand decorrelating filter is logically better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
